Add support for plain-CSS if() #2693
Merged
+6,264
−188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nex3
force-pushed
the
css-if
branch
3 times, most recently
from
dc3b5bf to
bf34802
Compare
This was referenced Dec 2, 2025
jathak
approved these changes
Dec 6, 2025
| IfExpression( | ||
| Iterable<(IfConditionExpression?, Expression)> branches, this.span) | ||
| : branches = List.unmodifiable(branches) { | ||
| if (this.branches.isEmpty) { |
Member
There was a problem hiding this comment.
if() with not branches is considered a valid (if not useful) plain CSS expression, at least according to MDN. Is the decision to require at least one branch in Sass intentional here?
Contributor
Author
There was a problem hiding this comment.
I believe MDN is inaccurate in this case. The spec defines the syntax as
<if()> = if( [ <if-branch> ; ]* <if-branch> ;? )
which clearly requires at least one branch.
This makes it easier for the migrator to handle functions with named arguments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See sass/sass#4155
See sass/sass-spec#2092